Skip to content

fix: correct NLB service prewarming when ReserveNlbNum=0#333

Merged
chrisliu1995 merged 2 commits into
openkruise:masterfrom
chrisliu1995:fix/nlbv2-reserve-0-prewarm
Apr 23, 2026
Merged

fix: correct NLB service prewarming when ReserveNlbNum=0#333
chrisliu1995 merged 2 commits into
openkruise:masterfrom
chrisliu1995:fix/nlbv2-reserve-0-prewarm

Conversation

@chrisliu1995
Copy link
Copy Markdown
Member

@chrisliu1995 chrisliu1995 commented Apr 23, 2026

  • Re-query NLB list after creating new NLBs in ensurePrewarming
  • Use NLBPoolIndexLabel instead of array index in prewarmServices
  • Add unit tests for reserve=0 prewarming scenarios
  • Add proposal document for the fix

@chrisliu1995
fix: correct NLB service prewarming when ReserveNlbNum=0
52ff0eb 
- Re-query NLB list after creating new NLBs in ensurePrewarming
- Use NLBPoolIndexLabel instead of array index in prewarmServices
- Add unit tests for reserve=0 prewarming scenarios
- Add proposal document for the fix
@kruise-bot kruise-bot requested review from FillZpp and zmberg April 23, 2026 09:10
@kruise-bot
Copy link
Copy Markdown

kruise-bot commented Apr 23, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zmberg for approval by writing /assign @zmberg in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.71%. Comparing base (c6c7386) to head (f21d687).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #333      +/-   ##
==========================================
- Coverage   40.77%   40.71%   -0.07%     
==========================================
  Files         112      112              
  Lines       12549    14951    +2402     
==========================================
+ Hits         5117     6087     +970     
- Misses       7020     8449    +1429     
- Partials      412      415       +3
Flag Coverage Δ
unittests 40.71% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kruise-bot kruise-bot added size/XL and removed size/L labels Apr 23, 2026
@chrisliu1995 chrisliu1995 merged commit 76382e0 into openkruise:master Apr 23, 2026
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FillZpp FillZpp Awaiting requested review from FillZpp

@zmberg zmberg Awaiting requested review from zmberg

Assignees

No one assigned

Labels

size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chrisliu1995 @kruise-bot